Skip to content

Apply Dynamic cfg to p2 & p3 cases #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

Apply Dynamic cfg to p2 & p3 cases #711

wants to merge 77 commits into from

Conversation

@snadrus
Copy link
Contributor

@snadrus snadrus commented Oct 17, 2025 •
edited
Loading

This builds atop PR #710 (which implemented P1 items) to implement P2 & P3 items of the following punchlist.
Logic fixes: forgot 'base' changes! Atomic where better.
New component: working with Dynamic[struct{...}] required a new approach.

Misc_Included_Commits
Better testing separation by guaranteeing different databases used.
SQL:

  • NEW: an AFTER trigger switched to BEFORE + modifying NEW so there's no window of time for error.
  • MOD: modified old code to help reapply work better. Should have no effect on fully-upgraded setups.

PunchList
The remaining items are P4-5 and "No need"

Subsystems

  • XXMax P4, medium difficulty

Fees - all P2, easy, done
Addresses - all P1, hard, done
Proving - all, P4, easy
Http - no need
Market

  • StorageMarketConfig
    -- MK12 - all here, P3, easy-ish, done
    -- MK2, P3, done
  • IPNI - P4
  • Indexing - P5, easy
  • PieceLocator - P2, easy, done

Ingest - P1, done
Seal - No need
APIs->Chain - P2, medium-hard, done
Alerting - P3, easy, done
Batching - P2, easy, done

@snadrus
dyncfg 90% done
e87c370
@snadrus
tests, docs, and clean-up
0662132
@snadrus
updates
260e345
@snadrus
checkers
0403006
@snadrus
allow cmp.Equal
d88a898
@snadrus
fixed dynamic
886dfd0
@snadrus
avoid unsettable
02772cc
@snadrus
Merge branch 'main' into dyn-cfg
de69e43
@snadrus
change-notification
3240f22
@snadrus
ingest-easy
e03333d
@snadrus
go mod tidy
bb71ceb
@snadrus
md
317fed1
@snadrus
address1
575f029
@snadrus
dbg basetext
cabb400
@snadrus
fix bad import
8f7a6ac
@snadrus
test logger
ff6ebdc
@snadrus
dbgFail: is it in baseTest
17f1050
@snadrus
found 1 blocker for test failure: base was not included right
aa24527
@snadrus
Merge branch 'dyn-cfg' into apply-dyn-cfg
65ae076
@snadrus
rm dbg
dcc4786
@snadrus
completed addresses
1808bc9
@snadrus
lint
3779387
@snadrus
move mineraddress onchange one level up
5d27fbc
@snadrus
no pq, fix unmarshal
2c0286e
@snadrus
complex equal
b9cb21c
@snadrus
Merge branch 'dyn-cfg' into apply-dyn-cfg
1e0a2e1
@snadrus
mod tidy & naming
deb9967
@snadrus
fix Fil cmp panic
6d721d8
@snadrus
Merge branch 'dyn-cfg' into apply-dyn-cfg
7282be5
@snadrus
transparent-decode
0127d96
@snadrus snadrus marked this pull request as draft October 23, 2025 22:04
@snadrus snadrus requested a review from magik6k October 23, 2025 23:40
@snadrus snadrus marked this pull request as ready for review October 30, 2025 14:13
@snadrus snadrus marked this pull request as draft November 6, 2025 23:56
@snadrus snadrus marked this pull request as ready for review November 7, 2025 22:52
@snadrus snadrus requested a review from LexLuthr November 7, 2025 22:59
@snadrus
Copy link
Contributor Author

snadrus commented Nov 10, 2025

I will add a test for the eth_client by moving money between wallets and back after a failover (how many lotus nodes, stop).

@Reiers
Copy link
Contributor

Reiers commented Nov 21, 2025 

nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: curio.service: Failed with result 'exit-code'.
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: curio.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/cmd/curio/main.go:206 +0x115d
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: main.main()
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/cmd/curio/main.go:234 +0x45
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: main.runApp(0x47ea9a0?)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:307
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*App).Run(...)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:333 +0x5a5
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*App).RunContext(0xc0002d8a00, {0x5dd72b8, 0x9ef9c00}, {0xc00004e180, 0x2, 0x2})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:269 +0xa45
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*Command).Run(0xc0004491e0, 0xc00043f880, {0xc00004e180, 0x2, 0x2})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:276 +0x7be
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*Command).Run(0x9cd1000, 0xc00077a000, {0xc000638c30, 0x1, 0x1})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/cmd/curio/run.go:120 +0x3d8
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: main.init.func27(0xc00077a000)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/deps.go:252 +0x815
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps.(*Deps).PopulateRemainingDeps(0xc000026120, {0x5dd7548, 0xc0005e25f0}, 0xc00077a000,  0x85?)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/apiinfo.go:120 +0x149
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps.GetFullNodeAPIV1Curio(0xc00077a000, 0xc000c02de0)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/apiinfo.go:117 +0xdc5
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps.GetFullNodeAPIV1Curio.func2()
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/config/dynamic.go:68 +0x239
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps/config.(*Dynamic[...]).Set(0x5dfdd80, {0xc0007c1160, 0x2, 0x2})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: goroutine 1 [running]:
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1ef5d39]
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: panic: runtime error: invalid memory address or nil pointer dereference
nov. 21 21:37:38 
neuranodes-storage-provider curio[1693204]: repopath ~/.curio
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: Started Curio.
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: Stopped Curio.
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: curio.service: Scheduled restart job, restart counter is at 5.
nov. 21 21:37:27 neuranodes-storage-provider systemd[1]: curio.service: Failed with result 'exit-code'.
nov. 21 21:37:27 neuranodes-storage-provider systemd[1]: curio.service: Main process exited, code=exited, status=2/INVALIDARGUMENT

Then reverting back to main:

PNG image PNG image PNG image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snadrus @Reiers